Skip to content

Tell about controllers in doc about service subscribers #9989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 4, 2018

Conversation

nicolas-grekas
Copy link
Member

Fixes #8872

Might need a link from ./controller.rst
Where do we tell about action injection btw?

@@ -13,7 +13,11 @@ instantiation of the services to be lazy. However, that's not possible using
the explicit dependency injection since services are not all meant to
be ``lazy`` (see :doc:`/service_container/lazy_services`).

A real-world example are applications that implement the `Command pattern`_
This can typically be the case in your controllers, where only one action is
usually called per request, and where services are used conditionnaly in each
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small typo here:

- conditionnaly
+ conditionally

@javiereguiluz
Copy link
Member

Thanks Nicolas.

@javiereguiluz javiereguiluz merged commit 81738f0 into symfony:3.4 Jul 4, 2018
javiereguiluz added a commit that referenced this pull request Jul 4, 2018
…nicolas-grekas, javiereguiluz)

This PR was merged into the 3.4 branch.

Discussion
----------

Tell about controllers in doc about service subscribers

Fixes #8872

Might  need a link from ./controller.rst
Where do we tell about action injection btw?

Commits
-------

81738f0 Minor rewords
e2e0b44 Tell about controllers in doc about service subscribers
@nicolas-grekas nicolas-grekas deleted the lazy-locators branch July 4, 2018 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants